netdev - Re: [PATCH 2/2] sky2: add support for receive hashing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4BD0F8AA.2060700@garzik.org>
Date:	Thu, 22 Apr 2010 21:32:26 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Stephen Hemminger <shemminger@...tta.com>
CC:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] sky2: add support for receive hashing

On 04/22/2010 07:42 PM, Stephen Hemminger wrote:
> +static int sky2_set_flags(struct net_device *dev, u32 data)
> +{
> +	struct sky2_port *sky2 = netdev_priv(dev);
> +
> +	if (data&  ETH_FLAG_LRO)
> +		return -EOPNOTSUPP;
> +
> +	if (data&  ETH_FLAG_NTUPLE)
> +		return -EOPNOTSUPP;


Minor nit:  you don't need separate tests for each bit.

	Jeff


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html