lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20100425.025143.196865359.davem@davemloft.net> Date: Sun, 25 Apr 2010 02:51:43 -0700 (PDT) From: David Miller <davem@...emloft.net> To: xiaosuo@...il.com Cc: xiaohui.xin@...el.com, netdev@...r.kernel.org, kvm@...r.kernel.org, linux-kernel@...r.kernel.org, mst@...hat.com, mingo@...e.hu, jdike@...ux.intel.com Subject: Re: [RFC][PATCH v4 05/18] Add a function to indicate if device use external buffer. From: Changli Gao <xiaosuo@...il.com> Date: Sun, 25 Apr 2010 17:33:02 +0800 > On Sun, Apr 25, 2010 at 5:19 PM, <xiaohui.xin@...el.com> wrote: >> +static int dev_is_mpassthru(struct net_device *dev) >> +{ >> + if (dev && dev->mp_port) >> + return 1; >> + return 0; >> +} >> + > > Please make it a inline function. And you would write it with less > lines of code. > > return dev && dev->mp_port; And use "bool" :-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists