lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <m1k4rvvb5x.fsf@fess.ebiederm.org> Date: Sun, 25 Apr 2010 07:50:34 -0700 From: ebiederm@...ssion.com (Eric W. Biederman) To: David Miller <davem@...emloft.net> Cc: jpirko@...hat.com, netdev@...r.kernel.org Subject: Re: [PATCH net-next-2.6] netns: call ops_free right after ops_exit David Miller <davem@...emloft.net> writes: > From: Jiri Pirko <jpirko@...hat.com> > Date: Sun, 25 Apr 2010 11:26:01 +0200 > >> There's no need to iterate this twice. We can free net generic >> variables right after exit is called. >> >> Signed-off-by: Jiri Pirko <jpirko@...hat.com> > > Are you sure there are no problems with doing this? > > What if there are inter-net variable reference dependencies > or something like that? > > I really suspect it is being done this way on purpose, but > in the end I defer to experts like Eric B. :-) I am pretty certain there is a problem. My memory is fuzzy this morning but I believe we can have rcu references between various pieces of the networking stack for a single network namespace. So we need to cause all of the network namespace to exit before it is safe to free those pieces. Eric -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists