lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20100425155600.GA13319@ioremap.net> Date: Sun, 25 Apr 2010 19:56:00 +0400 From: Evgeniy Polyakov <zbr@...emap.net> To: "Michael S. Tsirkin" <mst@...hat.com> Cc: Eric Dumazet <eric.dumazet@...il.com>, Ben Greear <greearb@...delatech.com>, David Miller <davem@...emloft.net>, Gaspar Chilingarov <gasparch@...il.com>, netdev <netdev@...r.kernel.org> Subject: Re: PROBLEM: Linux kernel 2.6.31 IPv4 TCP fails to open huge amount of outgoing connections (unable to bind ... ) On Sun, Apr 25, 2010 at 05:26:42PM +0300, Michael S. Tsirkin (mst@...hat.com) wrote: > > diff --git a/net/ipv6/inet6_connection_sock.c b/net/ipv6/inet6_connection_sock.c > > index 0c5e3c3..fb6959c 100644 > > --- a/net/ipv6/inet6_connection_sock.c > > +++ b/net/ipv6/inet6_connection_sock.c > > @@ -42,11 +42,16 @@ int inet6_csk_bind_conflict(const struct sock *sk, > > if (sk != sk2 && > > (!sk->sk_bound_dev_if || > > !sk2->sk_bound_dev_if || > > - sk->sk_bound_dev_if == sk2->sk_bound_dev_if) && > > - (!sk->sk_reuse || !sk2->sk_reuse || > > - sk2->sk_state == TCP_LISTEN) && > > - ipv6_rcv_saddr_equal(sk, sk2)) > > - break; > > + sk->sk_bound_dev_if == sk2->sk_bound_dev_if)) { > > + if ((!sk->sk_reuse || !sk2->sk_reuse || > > + sk2->sk_state == TCP_LISTEN) && > > + ipv6_rcv_saddr_equal(sk, sk2)) > > + break; > > + else if (sk->sk_reuse && sk2->sk_reuse && > > + !ipv6_addr_any(inet6_rcv_saddr(sk2)) && I suppose above line is guilty when inet6_rcv_saddr() returns NULL? -- Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists