netdev - Re: [PATCH v2] TCP: avoid to send keepalive probes if it is receiving data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100425235549.GB2550@sysclose.org>
Date:	Sun, 25 Apr 2010 20:55:49 -0300
From:	Flavio Leitner <fbl@...close.org>
To:	David Miller <davem@...emloft.net>
Cc:	ilpo.jarvinen@...sinki.fi, eric.dumazet@...il.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH v2] TCP: avoid to send keepalive probes if it is
 receiving data

On Wed, Apr 21, 2010 at 10:42:05PM -0700, David Miller wrote:
> From: "Ilpo Järvinen" <ilpo.jarvinen@...sinki.fi>
> Date: Sun, 18 Apr 2010 23:34:15 +0300 (EEST)
> 
> > I fail to see why the addition of this new variable is necessary at all, 
> > could either of you enlight me why exactly it's necessary and rcv_tstamp 
> > will not suffice?
> 
> I agree, the existing rcv_tstamp should serve this purpose just
> fine.

I thought it would break TCP_INFO/tcp_get_info(). Actually, reviewing
the code again I found another variable which does exactly what is needed.

I'll post a new patch for review.

thanks,
-- 
Flavio
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html