netdev - Re: [PATCH v2] tg3: Fix INTx fallback when MSI fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100426.111017.189698604.davem@davemloft.net>
Date:	Mon, 26 Apr 2010 11:10:17 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	adetsch@...ibm.com
Cc:	netdev@...r.kernel.org, mcarlson@...adcom.com, mchan@...adcom.com
Subject: Re: [PATCH v2] tg3: Fix INTx fallback when MSI fails

From: Andre Detsch <adetsch@...ibm.com>
Date: Mon, 26 Apr 2010 14:27:07 -0300

> tg3: Fix INTx fallback when MSI fails
> 
> MSI setup changes the value of irq_vec in struct tg3 *tp.
> This attribute must be taken into account and restored before
> we try to do a new request_irq for INTx fallback.
> 
> In powerpc, the original code was leading to an EINVAL return within
> request_irq, because the driver was trying to use the disabled MSI
> virtual irq number instead of tp->pdev->irq.
> 
> Signed-off-by: Andre Detsch <adetsch@...ibm.com>

Broadcom folks, I've already asked you to review Andre's original patch.

If you can't be bothered to look at and ACK/NACK a simple fix like
this for 10 days, then I'm just going to apply Andre's patch as-is
since it looks right to me.

If the idea was to bundle this up into a set of 15 patches you guys
already have ready to bomb at me, I absolutely do not want you guys to
operate that way.  It doesn't work.  You should be able to ACK a
simple patch like this as soon as possible so it can be integrated
upstream in the most expediant manner possible.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html