netdev - Re: [net-next-2.6 PATCH] ixgbe: ixgbe_down needs to stop dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 27 Apr 2010 12:56:11 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, gospo@...hat.com,
	john.r.fastabend@...el.com, peter.p.waskiewicz.jr@...el.com
Subject: Re: [net-next-2.6 PATCH] ixgbe: ixgbe_down needs to stop
 dev_watchdog

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Tue, 27 Apr 2010 05:13:39 -0700

> From: John Fastabend <john.r.fastabend@...el.com>
> 
> There is a small race between when the tx queues are stopped
> and when netif_carrier_off() is called in ixgbe_down.  If the
> dev_watchdog() timer fires during this time it is possible for
> a false tx timeout to occur.
> 
> This patch moves the netif_carrier_off() so that it is called before
> the tx queues are stopped preventing the dev_watchdog timer from
> detecting false tx timeouts.  The race is seen occosionally when
> FCoE or DCB settings are being configured or changed.
> 
> Testing note, running ifconfig up/down will not reproduce this
> issue because dev_open/dev_close call dev_deactivate() and then
> dev_activate().
> 
> Signed-off-by: John Fastabend <john.r.fastabend@...el.com>
> Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html