netdev - Re: [PATCH v5] rfs: Receive Flow Steering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1272406126.2343.17.camel@edumazet-laptop>
Date:	Wed, 28 Apr 2010 00:08:46 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	therbert@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH v5] rfs: Receive Flow Steering

Le mardi 27 avril 2010 à 14:59 -0700, David Miller a écrit :
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Mon, 26 Apr 2010 10:41:11 +0200
> 
> > Le lundi 19 avril 2010 à 14:19 -0700, David Miller a écrit :
> > 
> >> 
> >> I was thinking also about how we could compute rxhash in the
> >> loopback driver :-)
> > 
> > This would be easy if rxhash was not a "struct inet_sock" field but a
> > "struct sock" one
> > 
> > sock_alloc_send_pskb() (or skb_set_owner_w())
> > 
> > skb->rxhash = sk->rxhash;
> 
> Agreed.  I'll commit the following to net-next-2.6 after some build
> testing.
> 
> net: Make RFS socket operations not be inet specific.
> 
> Idea from Eric Dumazet.
> 
> As for placement inside of struct sock, I tried to choose a place
> that otherwise has a 32-bit hole on 64-bit systems.
> 
> Signed-off-by: David S. Miller <davem@...emloft.net>

Acked-by: Eric Dumazet <eric.dumazet@...il.com>

I tested same patch today (plus the skb->rxhash = sk->sk_rxhash) and got
a very small speedup on my Nehalem machine, where get_rps_cpus() was
using 1 % of cpu, now 0.25 %, on a tbench.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html