netdev - Re: [PATCH net-next] bridge: multicast router list manipulation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100427162530.04deb551@nehalam>
Date:	Tue, 27 Apr 2010 16:25:30 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Michał Mirosław <mirqus@...il.com>
Cc:	Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] bridge: multicast router list manipulation

On Wed, 28 Apr 2010 01:11:52 +0200
Michał Mirosław <mirqus@...il.com> wrote:

> 2010/4/27 Stephen Hemminger <shemminger@...tta.com>:
> > I prefer that the hlist be only accessed through the hlist macro
> > objects. Explicit twiddling of links (especially with RCU) exposes
> > the code to future bugs.
> [...]
> > -       port->rlist.pprev = h;
> > -       port->rlist.next = p;
> > -       rcu_assign_pointer(*h, &port->rlist);
> > -       if (p)
> > -               p->pprev = &port->rlist.next;
> > +       hlist_for_each_entry(p, n, &br->router_list, rlist) {
> 
> Shouldn't this be hlist_for_each_entry_rcu?
> 

This code should already be protected by br->multicast_lock
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html