netdev - Re: [PATCH v4] TCP: avoid to send keepalive probes if receiving data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100427.125512.220060084.davem@davemloft.net>
Date:	Tue, 27 Apr 2010 12:55:12 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ilpo.jarvinen@...sinki.fi
Cc:	fleitner@...hat.com, netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH v4] TCP: avoid to send keepalive probes if receiving
 data

From: "Ilpo Järvinen" <ilpo.jarvinen@...sinki.fi>
Date: Tue, 27 Apr 2010 09:08:08 +0300 (EEST)

> On Tue, 27 Apr 2010, Flavio Leitner wrote:
> 
>> RFC 1122 says the following:
>> ...
>>   Keep-alive packets MUST only be sent when no data or
>>   acknowledgement packets have been received for the
>>   connection within an interval.
>> ...
>> 
>> The acknowledgement packet is reseting the keepalive
>> timer but the data packet isn't. This patch fixes it by
>> checking the timestamp of the last received data packet
>> too when the keepalive timer expires.
>> 
>> Signed-off-by: Flavio Leitner <fleitner@...hat.com>
 ...
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
 ...
> Acked-by: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html