netdev - Re: [PATCH] forcedeth: Stay in NAPI as long as there's work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 Apr 2010 11:18:02 -0700
From:	Tom Herbert <therbert@...gle.com>
To:	Joe Perches <joe@...ches.com>
Cc:	netdev@...r.kernel.org, aabdulla@...dia.com, davem@...emloft.net
Subject: Re: [PATCH] forcedeth: Stay in NAPI as long as there's work

On Wed, Apr 28, 2010 at 11:07 AM, Tom Herbert <therbert@...gle.com> wrote:
>>
>> It might be better to test the comparisons using
>> a cpu_to_le32 of the constants.
>>
> Yes.  Probably should also be changed in nv_tx_done{_optimized} and
> nv_rx_process{_optimized}
>
Scratch that.  flags are checked all over the place in those other functions.

>> static inline int nv_has_work(struct fe_priv *np)
>> {
>>        if (nv_optimized(np))
>>                return ((np->get_rx.ex != np->put_rx.ex) &&
>>                        !(np->get_rx.ex->flaglen & cpu_to_le32(NV_RX2_AVAIL))) ||
>>                       ((np->get_tx.ex != np->put_tx.ex) &&
>>                        !(np->get_tx.ex->flaglen & cpu_to_le32(NV_TX_VALID)));
>>
>>        return ((np->get_rx.orig != np->put_rx.orig) &&
>>                !(np->get_rx.orig->flaglen & cpu_to_le32(NV_RX_AVAIL))) ||
>>               ((np->get_tx.orig != np->put_tx.orig) &&
>>                !(np->get_tx.orig->flaglen & cpu_to_le32(NV_TX_VALID)));
>> }
>>
>>
>>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html