netdev - Re: [PATCH v2] net/sb1250: register mdio bus in probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100428.143230.214243747.davem@davemloft.net>
Date:	Wed, 28 Apr 2010 14:32:30 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sebastian@...akpoint.cc
Cc:	ralf@...ux-mips.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2] net/sb1250: register mdio bus in probe

From: Sebastian Andrzej Siewior <sebastian@...akpoint.cc>
Date: Wed, 28 Apr 2010 21:57:01 +0200

> "ifconfig eth0 up && ifconfig eth0 down" triggers:
 ...
> mdiobus_register() calls device_register() which initializes the kobj of
> the device. mdiobus_unregister() calls only device_del() so we have one
> reference left. That one is leaving with mdiobus_free() which is only
> called on remove.
> Since I don't see any reason why mdiobus_register()/mdiobus_unregister()
> should happen in ->open()/->close() I move them to probe & exit.
> 
> Signed-off-by: Sebastian Andrzej Siewior <sebastian@...akpoint.cc>

This looks a lot better, applied, thanks Sebastian!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html