netdev - Re: [PATCH net-next-2.6] bnx2x: Remove two prefetch()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <g2ye8f3c3211004280844s9291cad9jab53e0bbd983c329@mail.gmail.com>
Date:	Wed, 28 Apr 2010 18:44:14 +0300
From:	Eliezer Tamir <eliezer@...ir.org.il>
To:	eilong@...adcom.com
Cc:	David Miller <davem@...emloft.net>, vladz@...adcom.com,
	"eric.dumazet@...il.com" <eric.dumazet@...il.com>,
	"xiaosuo@...il.com" <xiaosuo@...il.com>,
	"hadi@...erus.ca" <hadi@...erus.ca>,
	"therbert@...gle.com" <therbert@...gle.com>,
	"shemminger@...tta.com" <shemminger@...tta.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next-2.6] bnx2x: Remove two prefetch()

On Wed, Apr 28, 2010 at 4:14 PM, Eilon Greenstein <eilong@...adcom.com> wrote:
>
> On Tue, 2010-04-27 at 15:19 -0700, David Miller wrote:
> > From: Eric Dumazet <eric.dumazet@...il.com>
> > Date: Wed, 28 Apr 2010 00:18:13 +0200
> >
> > > [PATCH net-next-2.6] bnx2x: Remove two prefetch()
> > >
> > > 1) Even on 64bit arches, sizeof(struct sk_buff) < 256
> > > 2) No need to prefetch same pointer twice.
> > >
> > > Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> > > CC: Eilon Greenstein <eilong@...adcom.com>
> >
> > Eilon please review and ACK/NACK
>
> Vlad ran few benchmarks, and we couldn't find any justification for
> those prefetch calls. After consulting with Eliezer Tamir (the original
> author) we are glad to Ack this patch.
>
> Thanks Eric!
> Acked-by: <eilong@...adcom.com>
>
>
Normally, I would not have said anything but since Eilon asked.
Acked-by: <eliezer@...ir.org.il>
(this time in plain text)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html