netdev - Re: [PATCH] xfrm: potential uninitialized variable num

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100428.094155.09744376.davem@davemloft.net>
Date:	Wed, 28 Apr 2010 09:41:55 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	xiaosuo@...il.com
Cc:	hadi@...erus.ca, timo.teras@....fi, herbert@...dor.apana.org.au,
	adobriyan@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] xfrm: potential uninitialized variable num_xfrms

From: Changli Gao <xiaosuo@...il.com>
Date: Wed, 28 Apr 2010 15:20:22 +0800

> potential uninitialized variable num_xfrms
> 
> fix compiler warning: 'num_xfrms' may be used uninitialized in this function.
> 
> Signed-off-by: Changli Gao <xiaosuo@...il.com>

We've all been seeing it for weeks too, but I honestly have
reservations about trying to simply pacify the compiler here.

The num_xfrms variable is only used in code paths that actually
initialize it's value.  The compiler just can't see this in the
control flow.

Check it if you don't believe me.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html