netdev - possible off by one error in drivers/isdn/hysdn/hysdn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 30 Apr 2010 21:23:15 +0000
From:	d binderman <dcb314@...mail.com>
To:	<isdn@...ux-pingi.de>
CC:	<netdev@...r.kernel.org>
Subject: possible off by one error in drivers/isdn/hysdn/hysdn_proclog.c

Hello there,

I've just been looking at the Linux kernel linux-2.6.34-rc6.  I notice the
source code in file drivers/isdn/hysdn/hysdn_proclog.c, around line 115 is

        if (!(ib = kmalloc(sizeof(struct log_data) + strlen(cp), GFP_ATOMIC)))
                 return;        /* no memory */
        strcpy(ib->log_start, cp);      /* set output string */

Shouldn't that be

        if (!(ib = kmalloc(sizeof(struct log_data) + strlen(cp) + 1, GFP_ATOMIC)))
                 return;        /* no memory */
        strcpy(ib->log_start, cp);      /* set output string */

+1 for the zero byte ?

Regards

David Binderman

_________________________________________________________________
http://clk.atdmt.com/UKM/go/195013117/direct/01/
We want to hear all your funny, exciting and crazy Hotmail stories. Tell us now--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html