netdev - Re: [patch] ipv6: cleanup: remove unneeded null check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100430.164252.170100570.davem@davemloft.net>
Date:	Fri, 30 Apr 2010 16:42:52 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	error27@...il.com
Cc:	netdev@...r.kernel.org, kuznet@....inr.ac.ru, pekkas@...core.fi,
	jmorris@...ei.org, yoshfuji@...ux-ipv6.org, kaber@...sh.net,
	eric.dumazet@...il.com, sri@...ibm.com,
	herbert@...dor.apana.org.au, emils.tantilov@...il.com,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] ipv6: cleanup: remove unneeded null check

From: Dan Carpenter <error27@...il.com>
Date: Thu, 29 Apr 2010 16:30:35 +0200

> We dereference "sk" unconditionally elsewhere in the function.  
> 
> This was left over from:  b30bd282 "ip6_xmit: remove unnecessary NULL
> ptr check".  According to that commit message, "the sk argument to 
> ip6_xmit is never NULL nowadays since the skb->priority assigment 
> expects a valid socket."
> 
> Signed-off-by: Dan Carpenter <error27@...il.com>

Applied, thanks Dan.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html