lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20100501110000.GB9434@gargoyle.fritz.box> Date: Sat, 1 May 2010 13:00:00 +0200 From: Andi Kleen <andi@...stfloor.org> To: David Miller <davem@...emloft.net> Cc: eric.dumazet@...il.com, hadi@...erus.ca, xiaosuo@...il.com, therbert@...gle.com, shemminger@...tta.com, netdev@...r.kernel.org, lenb@...nel.org, arjan@...radead.org Subject: Re: [PATCH v6] net: batch skb dequeueing from softnet input_pkt_queue On Fri, Apr 30, 2010 at 04:38:57PM -0700, David Miller wrote: > From: Andi Kleen <ak@...goyle.fritz.box> > Date: Thu, 29 Apr 2010 23:41:44 +0200 > > > Use io_schedule() in network stack to tell cpuidle governour to guarantee lower latencies > > > > XXX: probably too aggressive, some of these sleeps are not under high load. > > > > Based on a bug report from Eric Dumazet. > > > > Signed-off-by: Andi Kleen <ak@...ux.intel.com> > > I like this, except that we probably don't want the delayacct_blkio_*() calls > these things do. Yes. It needs more work, please don't apply it yet, to handle the "long sleep" case. Still curious if it fixes Eric's test case. > > Probably the rest of what these things do should remain in the io_schedule*() > functions and the block layer can call it's own versions which add in the > delayacct_blkio_*() bits. Good point. > > Or, if the delacct stuff is useful for socket I/O too, then it's interfaces > names should have the "blk" stripped from them :-) Good question. I suspect it's actually useful for some cases, but just adding sockets might confuse some users. -Andi -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists