[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4BDC543F.7060500@trash.net>
Date: Sat, 01 May 2010 18:18:07 +0200
From: Patrick McHardy <kaber@...sh.net>
To: Simon Horman <horms@...ge.net.au>
CC: lvs-devel@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, netfilter@...r.kernel.org,
Wensong Zhang <wensong@...ux-vs.org>,
Julius Volz <julius.volz@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Hannes Eder <heder@...gle.com>,
Netfilter Development Mailinglist
<netfilter-devel@...r.kernel.org>
Subject: Re: [patch v2.2 1/4] [PATCH v2.1 1/4] netfilter: xt_ipvs (netfilter
matcher for IPVS)
Simon Horman wrote:
> @@ -0,0 +1,25 @@
> +#ifndef _XT_IPVS_H
> +#define _XT_IPVS_H 1
You don't need to define a value.
> +config NETFILTER_XT_MATCH_IPVS
> + tristate '"ipvs" match support'
> + depends on IP_VS
> + depends on NETFILTER_ADVANCED
> + help
> + This option allows you to match against IPVS properties of a packet.
> +
> + If unsure, say N.
You're using conntrack symbols, so this seems to need a dependency
on NF_CONNTRACK.
> +static bool ipvs_mt_check(const struct xt_mtchk_param *par)
We've changed the signature to "int" in nf-next to be able to
return errno codes. Please rebase your patches onto nf-next-2.6.git.
Please also CC netfilter-devel at least for those parts that affect
non-IPVS netfilter.
> +{
> + if (par->family != NFPROTO_IPV4
> +#ifdef CONFIG_IP_VS_IPV6
> + && par->family != NFPROTO_IPV6
> +#endif
> + ) {
> + pr_info("protocol family %u not supported\n", par->family);
> + return false;
> + }
> +
> + return true;
> +}
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists