netdev - Re: [PATCH] dm9601: fix phy/eeprom write routine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100503.152700.11978044.davem@davemloft.net>
Date:	Mon, 03 May 2010 15:27:00 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jacmet@...site.dk
Cc:	netdev@...r.kernel.org, michael.planes@...e.fr, stable@...nel.org
Subject: Re: [PATCH] dm9601: fix phy/eeprom write routine

From: Peter Korsgaard <jacmet@...site.dk>
Date: Mon,  3 May 2010 22:01:26 +0200

> Use correct bit positions in DM_SHARED_CTRL register for writes.
> 
> Michael Planes recently encountered a 'KY-RS9600 USB-LAN converter', which
> came with a driver CD containing a Linux driver. This driver turns out to
> be a copy of dm9601.c with symbols renamed and my copyright stripped.
> That aside, it did contain 1 functional change in dm_write_shared_word(),
> and after checking the datasheet the original value was indeed wrong
> (read versus write bits).
> 
> On Michaels HW, this change bumps receive speed from ~30KB/s to ~900KB/s.
> On other devices the difference is less spectacular, but still significant
> (~30%).
> 
> Reported-by: Michael Planes <michael.planes@...e.fr>
> CC: stable@...nel.org
> Signed-off-by: Peter Korsgaard <jacmet@...site.dk>

Applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html