netdev - Re: [PATCH] sky2: Avoid race in sky2_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 03 May 2010 16:36:12 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	mikem@...g3k.org, netdev@...r.kernel.org
Subject: Re: [PATCH] sky2: Avoid race in sky2_change_mtu

From: Stephen Hemminger <shemminger@...tta.com>
Date: Mon, 3 May 2010 16:26:34 -0700

> On Mon, 03 May 2010 23:18:56 +0900
> Mike McCormack <mikem@...g3k.org> wrote:
> 
>> netif_stop_queue does not ensure all in-progress transmits are complete,
>>  so use netif_tx_disable() instead.
>> 
>> Make sure NAPI polls are disabled, otherwise NAPI might trigger a TX
>>  restart between when we stop the queue and NAPI is disabled.
> 
> How could NAPI trigger a TX restart? Restart is a timer, not controlled
> by NAPI. There is a different race that your patch isn't covering.

I think he meant to say that NAPI can trigger a TX queue wake, which
indeed it can, and it will if there is space in the TX queue and
we happen to see the TXIDLE status at this time.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html