netdev - Re: [RFC] net-next: remove useless union keyword

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1272872647.2226.8.camel@edumazet-laptop>
Date:	Mon, 03 May 2010 09:44:07 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Changli Gao <xiaosuo@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [RFC] net-next: remove useless union keyword

Le lundi 03 mai 2010 à 05:53 +0800, Changli Gao a écrit :
> remove useless union keyword in rtable, rt6_info and dn_route.
> 
> Since there is only one member in a union, the union keyword isn't useful.
> 
> Signed-off-by: Changli Gao <xiaosuo@...il.com>
> ----


Thats right, in 2.6.20, next pointer was relocalised at the end of
'struct dst_entry' in commits 093c2ca4167cf66f69020329d14138da0da8599b
and 1e19e02ca0c5e33ea73a25127dbe6c3b8fcaac4b

The union trick is only needed in 'struct dst_entry'.

Please respin your patch against net-next-2.6

patching file net/ipv6/ip6_output.c
Hunk #1 succeeded at 701 (offset 1 line).
Hunk #3 succeeded at 743 (offset 1 line).
Hunk #5 succeeded at 788 (offset 1 line).
Hunk #7 succeeded at 1159 (offset 1 line).
Hunk #9 succeeded at 1227 (offset 1 line).
Hunk #11 succeeded at 1284 (offset 1 line).
Hunk #13 succeeded at 1506 (offset 1 line).


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html