netdev - Re: [patch 01/13] KS8851: Fix ks8851 snl transmit problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100503.141353.32722085.davem@davemloft.net>
Date:	Mon, 03 May 2010 14:13:53 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	Tristram.Ha@...rel.Com
Cc:	ben@...tec.co.uk, netdev@...r.kernel.org, support@...cantools.com
Subject: Re: [patch 01/13] KS8851: Fix ks8851 snl transmit problem

From: "Ha, Tristram" <Tristram.Ha@...rel.Com>
Date: Mon, 3 May 2010 14:11:41 -0700

> I thought the transmit check workqueue reschedules itself when the
> buffer available is still not enough, and this is the part you objected.

If it reschedules itself, it runs immediately.  That will just hog a cpu
endlessly until the TX packets start to be transmitted by the chip.  That's
just as bad a polling in a loop.

You need to use an hrtimer or similar.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html