netdev - Re: [PATCH] ipv4: udp: fix short packet and bad checksum logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 06 May 2010 16:48:00 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Bjørn Mork <bjorn@...k.no>
Cc:	netdev@...r.kernel.org, stable@...nel.org
Subject: Re: [PATCH] ipv4: udp: fix short packet and bad checksum logging

Le jeudi 06 mai 2010 à 15:44 +0200, Bjørn Mork a écrit :
> commit 2783ef23 moved the initialisation of saddr and daddr after
> pskb_may_pull() to avoid a potential data corruption.  Unfortunately
> also placing it after the short packet and bad checksum error paths,
> where these variables are used for logging.  The result is bogus
> output like
> 
> [92238.389505] UDP: short packet: From 2.0.0.0:65535 23715/178 to 0.0.0.0:65535
> 
> Moving the saddr and daddr initialisation above the error paths, while still
> keeping it after the pskb_may_pull() to keep the fix from commit 2783ef23.
> 
> Signed-off-by: Bjørn Mork <bjorn@...k.no>
> Cc: stable@...nel.org
> ---
>  net/ipv4/udp.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)

Well done :)

Acked-by: Eric Dumazet <eric.dumazet@...il.com>

To be backported to 2.6.29 and up kernels ;)



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html