netdev - Re: [net-next-2.6 V5 PATCH 2/3] Add ndo_{set|get}_vf_port_profile op support for enic dynamic vnics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C8083B9D.2EC18%scofeldm@cisco.com>
Date:	Thu, 06 May 2010 09:25:49 -0700
From:	Scott Feldman <scofeldm@...co.com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	<davem@...emloft.net>, <netdev@...r.kernel.org>,
	<chrisw@...hat.com>
Subject: Re: [net-next-2.6 V5 PATCH 2/3] Add ndo_{set|get}_vf_port_profile op
 support for enic dynamic vnics

On 5/6/10 6:47 AM, "Arnd Bergmann" <arnd@...db.de> wrote:

> On Thursday 06 May 2010, Scott Feldman wrote:
>> @@ -810,14 +819,24 @@ static void enic_reset_mcaddrs(struct enic *enic)
>>  
>>  static int enic_set_mac_addr(struct net_device *netdev, char *addr)
>>  {
>> -       if (!is_valid_ether_addr(addr))
>> -               return -EADDRNOTAVAIL;
>> +       struct enic *enic = netdev_priv(netdev);
>>  
>> -       memcpy(netdev->dev_addr, addr, netdev->addr_len);
>> +       if (enic_is_dynamic(enic)) {
>> +               random_ether_addr(netdev->dev_addr);
>> +       } else {
>> +               if (!is_valid_ether_addr(addr))
>> +                       return -EADDRNOTAVAIL;
>> +               memcpy(netdev->dev_addr, addr, netdev->addr_len);
>> +       }
>>  
>>         return 0;
>>  }
>>  
>> +static int enic_set_mac_address(struct net_device *netdev, void *p)
>> +{
>> +       return -EOPNOTSUPP;
>> +}
>> +
>>  /* netif_tx_lock held, BHs disabled */
>>  static void enic_set_multicast_list(struct net_device *netdev)
>>  {
> 
> Thsi looks funny. So you just ignore the address that gets passed to
> enic_set_mac_addr for dynamic interfaces and instead set a random
> address?

Dynamic enics have all-zero mac address on init, so we assign a random mac
addr to the interface.  This would seem less funny:

    if (enic_is_dynamic(enic) && is_zero_ether_addr(addr))
        random_ether_addr(netdev->dev_addr);
    else
        ...

I'll make that change and resubmit with your VDP additions if you like.

-scott

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html