netdev - Re: kernel panic when using netns+bridges+tc(netem)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100506.005425.220063166.davem@davemloft.net>
Date:	Thu, 06 May 2010 00:54:25 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	martin.ferrari@...il.com, arnd@...db.de, netdev@...r.kernel.org,
	mathieu.lacage@...hia.inria.fr
Subject: Re: kernel panic when using netns+bridges+tc(netem)

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 06 May 2010 08:59:47 +0200

> David, this is a stable candidate, once tested and acked, thanks !
> 
> [PATCH] veth: Dont kfree_skb() after dev_forward_skb()
> 
> In case of congestion, netif_rx() frees the skb, so we must assume
> dev_forward_skb() also consume skb.
> 
> Bug introduced by commit 445409602c092
> (veth: move loopback logic to common location)
> 
> We must change dev_forward_skb() to always consume skb, and veth to not
> double free it.
> 
> Bug report : http://marc.info/?l=linux-netdev&m=127310770900442&w=3
> 
> Reported-by: Martín Ferrari <martin.ferrari@...il.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Ugh, applied and queued up for -stable, thanks Eric!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html