netdev - Re: tip: origin tree boot crash (in the new micrel phy driver)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100506.031435.235688827.davem@davemloft.net>
Date:	Thu, 06 May 2010 03:14:35 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mingo@...e.hu
Cc:	david.choi@...rel.com, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: tip: origin tree boot crash (in the new micrel phy driver)

From: David Miller <davem@...emloft.net>
Date: Thu, 06 May 2010 03:10:40 -0700 (PDT)

> From: Ingo Molnar <mingo@...e.hu>
> Date: Thu, 6 May 2010 11:59:40 +0200
> 
>> I bisected it back to the following commit:
>> 
>> d05070091849015f8c5b7d55cd75b86ebb61b3ec is the first bad commit
>> commit d05070091849015f8c5b7d55cd75b86ebb61b3ec
>> Author: David J. Choi <david.choi@...rel.com>
>> Date:   Thu Apr 29 06:12:41 2010 +0000
>> 
>>     drivers/net/phy: micrel phy driver
 ...
>> Disabling the driver fixes the crash.
> 
> David please fix this crash, thanks.

Nevermind, Ingo please test this fix:

diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 0cd80e4..e67691d 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -32,6 +32,7 @@ static int kszphy_config_init(struct phy_device *phydev)
 
 static struct phy_driver ks8001_driver = {
 	.phy_id		= PHY_ID_KS8001,
+	.name		= "Micrel KS8001",
 	.phy_id_mask	= 0x00fffff0,
 	.features	= PHY_BASIC_FEATURES,
 	.flags		= PHY_POLL,
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html