[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20100506.215034.43036998.davem@davemloft.net>
Date: Thu, 06 May 2010 21:50:34 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: eric.dumazet@...il.com
Cc: bjorn@...k.no, netdev@...r.kernel.org
Subject: Re: [PATCH] ipv6: udp: make short packet logging consistent with
ipv4
From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 06 May 2010 16:49:26 +0200
> Le jeudi 06 mai 2010 à 15:44 +0200, Bjørn Mork a écrit :
>> Adding addresses and ports to the short packet log message,
>> like ipv4/udp.c does it, makes these messages a lot more useful:
>>
>> [ 822.182450] UDPv6: short packet: From [2001:db8:ffb4:3::1]:47839 23715/178 to [2001:db8:ffb4:3:5054:ff:feff:200]:1234
>>
>> This requires us to drop logging in case pskb_may_pull() fails,
>> which also is consistent with ipv4/udp.c
>>
>> Signed-off-by: Bjørn Mork <bjorn@...k.no>
>> ---
>> net/ipv6/udp.c | 11 ++++++++---
>> 1 files changed, 8 insertions(+), 3 deletions(-)
>
> Acked-by: Eric Dumazet <eric.dumazet@...il.com>
Applied to net-next-2.6, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists