netdev - Re: [PATCH net-next-2.6] rps: Various optimizations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100506.220759.25136752.davem@davemloft.net>
Date:	Thu, 06 May 2010 22:07:59 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, therbert@...gle.com
Subject: Re: [PATCH net-next-2.6] rps: Various optimizations

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 06 May 2010 10:58:42 +0200

> Introduce ____napi_schedule() helper for callers in irq disabled
> contexts. rps_trigger_softirq() becomes a leaf function.
> 
> Use container_of() in process_backlog() instead of accessing per_cpu
> address.
> 
> Use a custom inlined version of __napi_complete() in process_backlog()
> to avoid one locked instruction :
> 
>  only current cpu owns and manipulates this napi,
>  and NAPI_STATE_SCHED is the only possible flag set on backlog.
>  we can use a plain write instead of clear_bit(),
>  and we dont need an smp_mb() memory barrier, since RPS is on,
>  backlog is protected by a spinlock.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Looks great, applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html