netdev - Re: [Uclinux-dist-devel] [PATCH 09/11] netdev: bfin_mac: only use hardware checksum in normal IPv4 mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTil4XZW9MgGMjrAh2q6Ey28yibvy8q8SUs7-tp-7@mail.gmail.com>
Date:	Mon, 10 May 2010 11:35:46 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, jon.kowal@...ecialists.de,
	uclinux-dist-devel@...ckfin.uclinux.org
Subject: Re: [Uclinux-dist-devel] [PATCH 09/11] netdev: bfin_mac: only use 
	hardware checksum in normal IPv4 mode

On Mon, May 10, 2010 at 07:42, David Miller wrote:
> From: Mike Frysinger <vapier@...too.org>
> Date: Sun,  9 May 2010 06:18:55 -0400
>
>> From: Jon Kowal <jon.kowal@...ecialists.de>
>>
>> The Blackfin on-chip MAC checksum logic only works when the IP packet has
>> a header length of 20 bytes.  This is true for most IPv4 packets, but not
>> for IPv6 packets or IPv4 packets which use header options.  So only use
>> the hardware checksum when appropriate.
>>
>> Signed-off-by: Jon Kowal <jon.kowal@...ecialists.de>
>> Signed-off-by: Sonic Zhang <sonic.zhang@...log.com>
>> Signed-off-by: Mike Frysinger <vapier@...too.org>
>
> In order to make the tree bisectable, combine bug fixes into the changes
> that add the bugs instead of letting them live in the final tree when
> they don't need to.
>
> You should have just combined this patch into the patch that added the
> FCS inversion stuff.

i dont think that is true.  this bug existed before the FCS inversion
stuff -- notice the csum complete behavior changes.
-mike
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html