netdev - Re: [Uclinux-dist-devel] [PATCH 1/9] netdev: bfin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 May 2010 23:31:37 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Barry Song <21cnbao@...il.com>
Cc:	Richard Cochran <richardcochran@...il.com>, netdev@...r.kernel.org,
	Barry Song <barry.song@...log.com>,
	"David S. Miller" <davem@...emloft.net>,
	uclinux-dist-devel@...ckfin.uclinux.org
Subject: Re: [Uclinux-dist-devel] [PATCH 1/9] netdev: bfin_mac: add support 
	for IEEE 1588 PTP

On Tue, May 11, 2010 at 23:20, Barry Song wrote:
> On Wed, May 12, 2010 at 5:03 AM, Mike Frysinger wrote:
>> On Tue, May 11, 2010 at 03:07, Richard Cochran wrote:
>>> On Mon, May 10, 2010 at 11:39:06AM -0400, Mike Frysinger wrote:
>>>> diff --git a/drivers/net/bfin_mac.c b/drivers/net/bfin_mac.c
>>>> index 587f93c..6a9519f 100644
>>>> --- a/drivers/net/bfin_mac.c
>>>> +++ b/drivers/net/bfin_mac.c
>>> ...
>>>> +#define PTP_CLK 25000000
>>>> +
>>>> +static void bfin_mac_hwtstamp_init(struct net_device *netdev)
>>>> +{
>>>> +     struct bfin_mac_local *lp = netdev_priv(netdev);
>>>> +     u64 append;
>>>> +
>>>> +     /* Initialize hardware timer */
>>>> +     append = PTP_CLK * (1ULL << 32);
>>>> +     do_div(append, get_sclk());
>>>> +     bfin_write_EMAC_PTP_ADDEND((u32)append);
>>>
>>> It appears that one can tune this PTP clock.
>>>
>>> I recently posted a suggestion for a PTP clock class driver. Would you
>>> care to take a look at that and say whether that API would also work
>>> for the blackfin?
>>
>> i'm guessing you mean:
>> http://thread.gmane.org/gmane.linux.network/159179
>> http://thread.gmane.org/gmane.linux.network/159180
>> http://thread.gmane.org/gmane.linux.network/159181
>> http://thread.gmane.org/gmane.linux.network/159182
>>
>> Barry: could you take a look please ?
>
> I think the API can work for blackfin.  But our PTP driver is based on
> drivers/net/igb and has worked together with user-space PTPD utility.
> Here he is writing a different driver framework. It is not the moment
> for us to merge now. Maybe next kernel version after his patches have
> been popular.

i'm not going to merge them into our tree ahead of the net->mainline
merge.  Richard would just like some feedback on the proposed
framework to make sure it doesnt have limitations we'd have to fix
after things get merged.
-mike
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html