netdev - RE: [Pv-drivers] [PATCH 14/20] drivers/net/vmxnet3: Use kzalloc

Open Source and information security mailing list archives

Date:	Thu, 13 May 2010 14:20:43 -0700
From:	Bhavesh Davda <bhavesh@...are.com>
To:	Julia Lawall <julia@...u.dk>,
	Shreyas Bhatewara <sbhatewara@...are.com>,
	"VMware, Inc." <pv-drivers@...are.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [Pv-drivers] [PATCH 14/20] drivers/net/vmxnet3: Use kzalloc

Looks good. Thanks for doing this!

Signed-off-by: Bhavesh Davda <bhavesh@...are.com>

- Bhavesh

Bhavesh P. Davda

> -----Original Message-----
> From: pv-drivers-bounces@...are.com [mailto:pv-drivers-
> bounces@...are.com] On Behalf Of Julia Lawall
> Sent: Thursday, May 13, 2010 1:06 PM
> To: Shreyas Bhatewara; VMware, Inc.; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; kernel-janitors@...r.kernel.org
> Subject: [Pv-drivers] [PATCH 14/20] drivers/net/vmxnet3: Use kzalloc
> 
> From: Julia Lawall <julia@...u.dk>
> 
> Use kzalloc rather than the combination of kmalloc and memset.
> 
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> expression x,size,flags;
> statement S;
> @@
> 
> -x = kmalloc(size,flags);
> +x = kzalloc(size,flags);
>  if (x == NULL) S
> -memset(x, 0, size);
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@...u.dk>
> 
> ---
>  drivers/net/vmxnet3/vmxnet3_drv.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff -u -p a/drivers/net/vmxnet3/vmxnet3_drv.c
> b/drivers/net/vmxnet3/vmxnet3_drv.c
> --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> @@ -1369,13 +1369,12 @@ vmxnet3_rq_create(struct vmxnet3_rx_queu
> 
>  	sz = sizeof(struct vmxnet3_rx_buf_info) * (rq->rx_ring[0].size +
>  						   rq->rx_ring[1].size);
> -	bi = kmalloc(sz, GFP_KERNEL);
> +	bi = kzalloc(sz, GFP_KERNEL);
>  	if (!bi) {
>  		printk(KERN_ERR "%s: failed to allocate rx bufinfo\n",
>  		       adapter->netdev->name);
>  		goto err;
>  	}
> -	memset(bi, 0, sz);
>  	rq->buf_info[0] = bi;
>  	rq->buf_info[1] = bi + rq->rx_ring[0].size;
> 
> _______________________________________________
> Pv-drivers mailing list
> Pv-drivers@...are.com
> http://mailman2.vmware.com/mailman/listinfo/pv-drivers
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives