netdev - Re: [PATCH] netfilter: Remove skb_is_nonlinear check from nf_conntrack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.01.1005140849500.28602@obet.zrqbmnf.qr>
Date:	Fri, 14 May 2010 08:50:24 +0200 (CEST)
From:	Jan Engelhardt <jengelh@...ozas.de>
To:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
cc:	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] netfilter: Remove skb_is_nonlinear check from
 nf_conntrack_sip

On Friday 2010-05-14 02:38, Jason Gunthorpe wrote:

>At least the XEN net front driver always produces non linear skbs,
>so the SIP module does nothing at all when used with that NIC.
>
>Copy the hacky technique for accessing SKB data from the ftp conntrack,
>better than nothing..
>
>Signed-off-by: Jason Gunthorpe <jgunthorpe@...idianresearch.com>
> 
>+/* This is slow, but it's simple. --RR */
>+static char *sip_buffer;
>+static DEFINE_SPINLOCK(nf_sip_lock);
>+

skb_linearize seems simpler. (What about the cost?)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html