netdev - Re: [PATCH V2 net-next] drivers/net: Remove unnecessary returns from void function()s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100514.001945.52204757.davem@davemloft.net>
Date:	Fri, 14 May 2010 00:19:45 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH V2 net-next] drivers/net: Remove unnecessary returns
 from void function()s

From: Joe Perches <joe@...ches.com>
Date: Thu, 13 May 2010 23:03:00 -0700

> On Thu, 2010-05-13 at 19:09 -0700, David Miller wrote:
>> Ok, please remake this patch with those cases removed.
> 
> This patch removes from drivers/net/ all the unnecessary
> return; statements that precede the last closing brace of
> void functions.
> 
> It does not remove the returns that are immediately
> preceded by a label as gcc doesn't like that.
> 
> It also does not remove null void functions with return.
> 
> Done via:
> $ grep -rP --include=*.[ch] -l "return;\n}" net/ | \
>   xargs perl -i -e 'local $/ ; while (<>) { s/\n[ \t\n]+return;\n}/\n}/g; print; }'
> 
> with some cleanups by hand.
> 
> Compile tested x86 allmodconfig only.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Applied, thanks a lot Joe.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html