lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20100516230135.GA3112@sortiz.org> Date: Mon, 17 May 2010 01:01:36 +0200 From: Samuel Ortiz <samuel.ortiz@...el.com> To: Julia Lawall <julia@...u.dk> Cc: "Zhu, Yi" <yi.zhu@...el.com>, Intel Linux Wireless <ilw@...ux.intel.com>, "John W. Linville" <linville@...driver.com>, "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org> Subject: Re: [PATCH 13/37] drivers/net/wireless/iwmc3200wifi: Use kmemdup On Sat, May 15, 2010 at 10:16:58PM +0100, Julia Lawall wrote: > From: Julia Lawall <julia@...u.dk> > > Use kmemdup when some other buffer is immediately copied into the > allocated region. > > A simplified version of the semantic patch that makes this change is as > follows: (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression from,to,size,flag; > statement S; > @@ > > - to = \(kmalloc\|kzalloc\)(size,flag); > + to = kmemdup(from,size,flag); > if (to==NULL || ...) S > - memcpy(to, from, size); > // </smpl> > > Signed-off-by: Julia Lawall <julia@...u.dk> Acked-by: Samuel Ortiz <sameo@...ux.intel.com> Cheers, Samuel. > --- > drivers/net/wireless/iwmc3200wifi/rx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff -u -p a/drivers/net/wireless/iwmc3200wifi/rx.c b/drivers/net/wireless/iwmc3200wifi/rx.c > --- a/drivers/net/wireless/iwmc3200wifi/rx.c > +++ b/drivers/net/wireless/iwmc3200wifi/rx.c > @@ -321,14 +321,14 @@ iwm_rx_ticket_node_alloc(struct iwm_priv > return ERR_PTR(-ENOMEM); > } > > - ticket_node->ticket = kzalloc(sizeof(struct iwm_rx_ticket), GFP_KERNEL); > + ticket_node->ticket = kmemdup(ticket, sizeof(struct iwm_rx_ticket), > + GFP_KERNEL); > if (!ticket_node->ticket) { > IWM_ERR(iwm, "Couldn't allocate RX ticket\n"); > kfree(ticket_node); > return ERR_PTR(-ENOMEM); > } > > - memcpy(ticket_node->ticket, ticket, sizeof(struct iwm_rx_ticket)); > INIT_LIST_HEAD(&ticket_node->node); > > return ticket_node; -- Intel Open Source Technology Centre http://oss.intel.com/ --------------------------------------------------------------------- Intel Corporation SAS (French simplified joint stock company) Registered headquarters: "Les Montalets"- 2, rue de Paris, 92196 Meudon Cedex, France Registration Number: 302 456 199 R.C.S. NANTERRE Capital: 4,572,000 Euros This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists