netdev - Re: [PATCH] rtnetlink: make SR-IOV VF interface symmetric

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100517161043.GB8301@sequoia.sous-sol.org>
Date:	Mon, 17 May 2010 09:10:43 -0700
From:	Chris Wright <chrisw@...s-sol.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Chris Wright <chrisw@...s-sol.org>, davem@...emloft.net,
	kaber@...sh.net, mitch.a.williams@...el.com, scofeldm@...co.com,
	shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [PATCH] rtnetlink: make SR-IOV VF interface symmetric

* Arnd Bergmann (arnd@...db.de) wrote:
> On Saturday 15 May 2010 05:14:16 Chris Wright wrote:
> > Now we have a set of nested attributes:
> > 
> >   IFLA_VFINFO_LIST (NESTED)
> >     IFLA_VF_INFO (NESTED)
> >       IFLA_VF_MAC
> >       IFLA_VF_VLAN
> >       IFLA_VF_TX_RATE
> > 
> > This allows a single set to operate on multiple attributes if desired.
> > Among other things, it means a dump can be replayed to set state.
> > 
> > The current interface has yet to be released, so this seems like
> > something to consider for 2.6.34.
> > 
> > Signed-off-by: Chris Wright <chrisw@...s-sol.org
> 
> Very nice! This would be the minimum change to make the ABI conform
> to the general rules, so it would be really good to have that.
> 
> Acked-by: Arnd Bergmann <arnd@...db.de>
> 
> It does make the interface a bit strange (less than before), since the
> new IFLA_VF_INFO now contains three nested attributes that each contain their
> own vf number field, and we don't require that they are identical or that
> each of the nested attributes inside VF_INFO appears only once.
> 
> How about a second patch that splits out an IFLA_VF_NUMBER attribute
> and makes do_setvfinfo use nla_parse_nested instead of nla_for_each_nested
> in order to tighten the rules on this some more?

Yes, that's a great idea Arnd.  I'll tighten that up.

thanks,
-chris
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html