netdev - Re: [RFC] netem: correlated loss generation (v3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1274159961.2567.26.camel@edumazet-laptop>
Date:	Tue, 18 May 2010 07:19:21 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	Stefano Salsano <stefano.salsano@...roma2.it>,
	David Miller <davem@...emloft.net>,
	Fabio Ludovici <fabio.ludovici@...oo.it>,
	netdev@...r.kernel.org, netem@...ts.linuxfoundation.org
Subject: Re: [RFC] netem: correlated loss generation (v3)

Le lundi 17 mai 2010 à 20:56 -0700, Stephen Hemminger a écrit :
> Subject: netem - revised correlated loss generator
> 
> This is a patch originated with Stefano Salsano and Fabio Ludovici.
> It provides several alternative loss models for use with netem.
> There are two state machine based models and one table driven model.
> 
> To simplify the original code:
>    * eliminated the debugging messages and statistics
>    * reformatted for clarity
>    * changed API to nested attribute relating to loss
>    * changed the table to always loop across bits
>    * only allocate parameters needed
> 
> Still untested, for comment only...
> Should have tested version before 2.6.35 merge window closes.
> 
> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>


> +	if (loss[NETEM_LOSS_SEQUENCE]) {
> +		struct dlgtable *dlg;
> +		size_t len = nla_len(loss[NETEM_LOSS_SEQUENCE]);
> +
> +		dlg = kmalloc(sizeof(*dlg) + len, GFP_KERNEL);

No overflow check here, len comes from userland.

> +		if (dlg)
> +			goto nomem;
> +
> +		dlg->length = len * BITS_PER_LONG;
> +		dlg->index = 0;
> +		memcpy(dlg->sequence, nla_data(loss[NETEM_LOSS_SEQUENCE]), len);
> +
> +		kfree(q->dlg);
> +		q->dlg = dlg;
> +	}
> +
> +	q->loss_model = model;
> +	sch_tree_unlock(sch);


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html