[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20100517.172145.260079154.davem@davemloft.net>
Date: Mon, 17 May 2010 17:21:45 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: vapier@...too.org
Cc: netdev@...r.kernel.org, uclinux-dist-devel@...ckfin.uclinux.org,
sonic.zhang@...log.com, jon.kowal@...ecialists.de
Subject: Re: [PATCH 4/9 v2] netdev: bfin_mac: deduce Ethernet FCS from
hardware IP payload checksum
From: Mike Frysinger <vapier@...too.org>
Date: Mon, 10 May 2010 11:39:09 -0400
> From: Sonic Zhang <sonic.zhang@...log.com>
>
> IP checksum is based on 16-bit one's complement algorithm, so to deduce a
> value from checksum is equal to add its complement.
>
> Unfortunately, the Blackfin on-chip MAC checksum logic only works when the
> IP packet has a header length of 20 bytes. This is true for most IPv4
> packets, but not for IPv6 packets or IPv4 packets which use header options.
> So only use the hardware checksum when appropriate.
>
> Signed-off-by: Sonic Zhang <sonic.zhang@...log.com>
> Signed-off-by: Jon Kowal <jon.kowal@...ecialists.de>
> Signed-off-by: Mike Frysinger <vapier@...too.org>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists