netdev - Re: [PATCH] bfin_mac: fix memleak in mii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTikcB3f0KmkcnDsV46Xrpm3WcCLQklxbLSJfMTlW@mail.gmail.com>
Date:	Tue, 18 May 2010 18:05:11 +0800
From:	Sonic Zhang <sonic.adi@...il.com>
To:	kirjanov@...il.com, davem@...emloft.net,
	michael.hennerich@...log.com, sonic.zhang@...log.com,
	cooloney@...nel.org, uclinux-dist-devel@...ckfin.uclinux.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] bfin_mac: fix memleak in mii_bus{probe|remove}

2010/5/18 Denis Kirjanov <kirjanov@...il.com <kirjanov@...il.com>:
> Fix memory leak with miibus->irq
>
> Signed-off-by: Denis Kirjanov <dkirjanov@...nel.org>
> ---
>
> drivers/net/bfin_mac.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/bfin_mac.c b/drivers/net/bfin_mac.c
> index 39a54ba..7a17b8a 100644
> --- a/drivers/net/bfin_mac.c
> +++ b/drivers/net/bfin_mac.c
> @@ -1627,6 +1627,7 @@ static int __devinit bfin_mii_bus_probe(struct platform_device *pdev)
>
>  out_err_mdiobus_register:
>        mdiobus_free(miibus);
> +       kfree(miibus->irq);

Should you move this kfree before mdiobus_free?

>  out_err_alloc:
>        peripheral_free_list(pin_req);
>
> @@ -1638,6 +1639,7 @@ static int __devexit bfin_mii_bus_remove(struct platform_device *pdev)
>        struct mii_bus *miibus = platform_get_drvdata(pdev);
>        platform_set_drvdata(pdev, NULL);
>        mdiobus_unregister(miibus);
> +       kfree(miibus->irq);
>        mdiobus_free(miibus);
>        peripheral_free_list(pin_req);
>        return 0;
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html