netdev - Re: [PATCH] sh_eth: Fix memleak in sh_mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 May 2010 07:12:21 +0900
From:	Nobuhiro Iwamatsu <iwamatsu@...auri.org>
To:	Denis Kirjanov <dkirjanov@...a.kernel.org>
Cc:	davem@...emloft.net, shimoda.yoshihiro@...esas.com,
	morimoto.kuninori@...esas.com, netdev@...r.kernel.org
Subject: Re: [PATCH] sh_eth: Fix memleak in sh_mdio_release

Hi, Denis.

2010/5/20 Denis Kirjanov <dkirjanov@...a.kernel.org>:
> Allocated memory for IRQs should be freed when releasing the mii_bus
>
> Signed-off-by: Denis Kirjanov <dkirjanov@...nel.org>
> ---
>
> drivers/net/sh_eth.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/sh_eth.c b/drivers/net/sh_eth.c
> index 586ed09..501a55f 100644
> --- a/drivers/net/sh_eth.c
> +++ b/drivers/net/sh_eth.c
> @@ -1294,6 +1294,9 @@ static int sh_mdio_release(struct net_device *ndev)
>        /* remove mdio bus info from net_device */
>        dev_set_drvdata(&ndev->dev, NULL);
>
> +       /* free interrupts memory */
> +       kfree(bus->irq);
> +
>        /* free bitbang info */
>        free_mdio_bitbang(bus);
>
>
Acked-by: Nobuhiro Iwamatsu <iwamatsu@...auri.org>

Thanks!

Best regards,
  Nobuhiro
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html