| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <201005211625.06234.opurdila@ixiacom.com> Date: Fri, 21 May 2010 16:25:06 +0300 From: Octavian Purdila <opurdila@...acom.com> To: Daniel Lezcano <daniel.lezcano@...e.fr> Cc: davem@...emloft.net, netdev@...r.kernel.org Subject: Re: [PATCH] net-2.6 : V2 - fix dev_get_valid_name On Friday 21 May 2010 16:10:13 you wrote: > On 05/19/2010 10:12 PM, Daniel Lezcano wrote: > > the commit: > > > > commit d90310243fd750240755e217c5faa13e24f41536 > > Author: Octavian Purdila<opurdila@...acom.com> > > Date: Wed Nov 18 02:36:59 2009 +0000 > > > > net: device name allocation cleanups > > > > introduced a bug when there is a hash collision making impossible > > to rename a device with eth%d. This bug is very hard to reproduce > > and appears rarely. > > > > The problem is coming from we don't pass a temporary buffer to > > __dev_alloc_name but 'dev->name' which is modified by the function. > > > > A detailed explanation is here: > > > > http://marc.info/?l=linux-netdev&m=127417784011987&w=2 > > > > Changelog: > > V2 : replaced strings comparison by pointers comparison > > > > Signed-off-by: Daniel Lezcano<daniel.lezcano@...e.fr> > > --- > > Octavian, are you ok with this patch ? > Yes, all looks good to me, thanks for the fix. Reviewed-by: Octavian Purdila <opurdila@...acom.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists