netdev - Re: [PATCH v2 1/2] phylib: Convert MDIO and PHY Lib drivers to support 10G

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1274468125.2089.4.camel@achroite.uk.solarflarecom.com>
Date:	Fri, 21 May 2010 19:55:25 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Andy Fleming <afleming@...escale.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH v2 1/2] phylib: Convert MDIO and PHY Lib drivers to
 support 10G

On Fri, 2010-05-21 at 13:31 -0500, Andy Fleming wrote:
[...]
> diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
> index 1a99bb2..c72ba85 100644
> --- a/drivers/net/phy/phy_device.c
> +++ b/drivers/net/phy/phy_device.c
[...]
> @@ -873,6 +941,36 @@ static int genphy_config_init(struct phy_device *phydev)
>  
>  	return 0;
>  }
> +
> +/* Replicate mdio45_probe */
> +int gen10g_config_init(struct phy_device *phydev)
> +{
> +	int mmd, stat2, devs1, devs2;
> +
> +	phydev->supported = phydev->advertising = SUPPORTED_10000baseT_Full;
[...]

Whyever are you assuming that?

> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index 987e111..8fb1b52 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
[...]
> @@ -62,7 +63,8 @@ typedef enum {
>  	PHY_INTERFACE_MODE_RGMII_ID,
>  	PHY_INTERFACE_MODE_RGMII_RXID,
>  	PHY_INTERFACE_MODE_RGMII_TXID,
> -	PHY_INTERFACE_MODE_RTBI
> +	PHY_INTERFACE_MODE_RTBI,
> +	PHY_INTERFACE_MODE_XGMII
>  } phy_interface_t;
[...]

What about XAUI and XFI?  I don't think anyone uses XGMII other than as
an on-chip interface.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html