netdev - Re: tc: RTM_GETQDISC causes kernel OOPS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1274531509.12793.7.camel@bigi>
Date:	Sat, 22 May 2010 08:31:49 -0400
From:	jamal <hadi@...erus.ca>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	Eric Dumazet <eric.dumazet@...il.com>, Ben Pfaff <blp@...ira.com>,
	netdev@...r.kernel.org
Subject: Re: tc: RTM_GETQDISC causes kernel OOPS

On Sat, 2010-05-22 at 11:51 +0200, Patrick McHardy wrote:

> 
> We already use TCQ_F_BUILTIN in tc_qdisc_dump_ignore(), so I
> think it would be more consistent than checking for a handle
> to use it here as well.

Agree - it is more semantically correct..

I wonder though if it is better to do the check in tc_get_qdisc()
and tc_modify_qdisc()?

cheers,
jamal

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html