netdev - Re: [PATCH 1/5] net/phy/marvell: Expose IDs and flags in a .h and add dns323 LEDs setup flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 22 May 2010 15:06:24 +0200
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>, netdev@...r.kernel.org,
	Nicolas Pitre <nico@...xnic.net>
Subject: Re: [PATCH 1/5] net/phy/marvell: Expose IDs and flags in a .h and
	add dns323 LEDs setup flag

On Sat, May 22, 2010 at 08:54:43PM +1000, Benjamin Herrenschmidt wrote:
> This moves the various known Marvell PHY IDs to include/linux/marvell_phy.h
> along with dev_flags definitions for use by the driver.

I think this one from the driver should go there, too:

#define M1145_DEV_FLAGS_RESISTANCE      0x00000001

(which makes me wonder how this flag was set as it was not exported before)

and thus yours could be maybe like

#define M1118_DEV_FLAGS_ALT_LED_INIT	0x00000001

(or 1 << 0)

?

Otherwise looks good enough to me.

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)