netdev - bug report: xfrm: potential null deref in xfrm_bundle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100522202430.GN22515@bicker>
Date:	Sat, 22 May 2010 22:24:30 +0200
From:	Dan Carpenter <error27@...il.com>
To:	timo.teras@....fi
Cc:	netdev@...r.kernel.org
Subject: bug report: xfrm: potential null deref in xfrm_bundle_lookup()

This is a smatch thing.  I couldn't tell if it was a real issue so I
thought I would send this mail to the experts.  :)

net/xfrm/xfrm_policy.c +1679 xfrm_bundle_lookup(51)
	error: we previously assumed 'xdst' could be null.
  1672          new_xdst = xfrm_resolve_and_create_bundle(pols, num_pols, fl, family, dst_orig);
  1673          if (IS_ERR(new_xdst)) {
  1674                  err = PTR_ERR(new_xdst);
  1675                  if (err != -EAGAIN)
  1676                          goto error;
  1677                  if (oldflo == NULL)
  1678                          goto make_dummy_bundle;
  1679                  dst_hold(&xdst->u.dst);
                                  ^^^^^^^^^^^
	Can xdst be NULL here?  It would have to be something like
	oldflo gets passed in as null and __xfrm_policy_lookup() fails.

  1680                  return oldflo;
  1681          }

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html