netdev - Re: [patch] e1000e: change logical negate to bitwise

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTil3USy0GrLLgShygH8PpOZPmVHwH5oSvNarAOhk@mail.gmail.com>
Date:	Sat, 22 May 2010 18:01:27 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Dan Carpenter <error27@...il.com>
Cc:	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	Bruce Allan <bruce.w.allan@...el.com>,
	Alex Duyck <alexander.h.duyck@...el.com>,
	PJ Waskiewicz <peter.p.waskiewicz.jr@...el.com>,
	John Ronciak <john.ronciak@...el.com>,
	"David S. Miller" <davem@...emloft.net>,
	e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] e1000e: change logical negate to bitwise

On Sat, May 22, 2010 at 12:45, Dan Carpenter <error27@...il.com> wrote:
> The bitwise negate is intended here.  With the logical negate the
> condition is always false.
>
> Signed-off-by: Dan Carpenter <error27@...il.com>
>
> diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
> index 24507f3..57a7e41 100644
> --- a/drivers/net/e1000e/netdev.c
> +++ b/drivers/net/e1000e/netdev.c
> @@ -2554,7 +2554,7 @@ static void e1000_init_manageability_pt(struct e1000_adapter *adapter)
>                        mdef = er32(MDEF(i));
>
>                        /* Ignore filters with anything other than IPMI ports */
> -                       if (mdef & !(E1000_MDEF_PORT_623 | E1000_MDEF_PORT_664))
> +                       if (mdef & ~(E1000_MDEF_PORT_623 | E1000_MDEF_PORT_664))
>                                continue;
>
>                        /* Enable this decision filter in MANC2H */
> --

Thanks Dan, I have added the patch to my queue.

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html