netdev - Re: [PATCH] ethoc: fix null dereference in ethoc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100523.231124.236272338.davem@davemloft.net>
Date:	Sun, 23 May 2010 23:11:24 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	thomas@...ron.com.tw
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	thierry.reding@...onic-design.de, nios2-dev@...c.et.ntust.edu.tw,
	error27@...il.com
Subject: Re: [PATCH] ethoc: fix null dereference in ethoc_probe

From: Thomas Chou <thomas@...ron.com.tw>
Date: Mon, 24 May 2010 10:44:02 +0800

> Dan reported the patch 0baa080c75c: "ethoc: use system memory
> as buffer" introduced a potential null dereference.
> 
>   1060  free:
>   1061          if (priv->dma_alloc)
>                     ^^^^^^^^^^^^^^^
> 	priv can be null here.
> 
> He also suggested that the error handling is not complete.
> 
> This patch fixes the null priv issue and improves resources
> releasing in ethoc_probe() and ethoc_remove().
> 
> Reported-by: Dan Carpenter <error27@...il.com>
> Signed-off-by: Thomas Chou <thomas@...ron.com.tw>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html