netdev - Re: cls_cgroup: Store classid in struct sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100523.235557.165343768.davem@davemloft.net>
Date:	Sun, 23 May 2010 23:55:57 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	nhorman@...driver.com, eric.dumazet@...il.com, bmb@...enacr.com,
	tgraf@...hat.com, nhorman@...hat.com, netdev@...r.kernel.org
Subject: Re: cls_cgroup: Store classid in struct sock

From: David Miller <davem@...emloft.net>
Date: Sun, 23 May 2010 23:44:41 -0700 (PDT)

> From: Herbert Xu <herbert@...dor.apana.org.au>
> Date: Sat, 22 May 2010 11:49:57 +1000
> 
>> On Fri, May 21, 2010 at 12:40:54PM -0400, Neil Horman wrote:
>>> 
>>> There may also be an issue with the setting of the classid (possible use of the
>>> wrong subsys id value when grabbing our cgroup_subsys_state), but I'm checking
>>> on that now.
>> 
>> Actually, I think it's because my patch mistook CONFIG_CGROUP
>> for CONFIG_CGROUPS.
>> 
>> Here is a fixed version (also includes a build fix on sk->classid).
>> 
>> cls_cgroup: Store classid in struct sock
> 
> BTW I made sure to apply this version.

Actually I had to revert, doesn't build:

  CC [M]  drivers/net/pppoe.o
In file included from net/socket.c:97:
include/net/cls_cgroup.h:22: error: field ‘css’ has incomplete type
make[1]: *** [net/socket.o] Error 1
make: *** [net] Error 2
make: *** Waiting for unfinished jobs....

Probably you only tested the build with cgroups enabled?