netdev - Question about an assignment in handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100524112236.GF2810@psychotron.lab.eng.brq.redhat.com>
Date:	Mon, 24 May 2010 13:22:36 +0200
From:	Jiri Pirko <jpirko@...hat.com>
To:	hadi@...erus.ca
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	herbert@...dor.hengli.com.au, kaber@...sh.net
Subject: Question about an assignment in handle_ing()

Hi Jamal.

I want to ask you about the following chunk of code of net/core/dev.c in function handle_ing():

2699        if (*pt_prev) {
2700                *ret = deliver_skb(skb, *pt_prev, orig_dev);
2701                *pt_prev = NULL;
2702        } else {
2703                /* Huh? Why does turning on AF_PACKET affect this? */
2704                skb->tc_verd = SET_TC_OK2MUNGE(skb->tc_verd);
2705        }

The assignment (in "else" statement) was added by you here:
http://linux.bkbits.net:8080/linux-2.6.12-stable/?PAGE=cset&REV=40cfc085xjyQLyB1UiTbgaRZSlCN9w

The comment was added after move of this code by Herbert:
http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=commitdiff;h=f697c3e8b35c18b2698d64137c0fa84b0cdb3d10

Question is if this code is correct here. Maybe I'm missing something but
why is this dependent on a ptype was found previously?

Thanks,

	Jirka
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html