netdev - Re: [patch v2] caif: cleanup: remove duplicate checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTilHv7m-oJSlXHJRLT9BLKscGLSFnGVCOB9U0kic@mail.gmail.com>
Date:	Mon, 24 May 2010 22:47:41 +0200
From:	Sjur Brændeland <sjurbren@...il.com>
To:	Dan Carpenter <error27@...il.com>
Cc:	walter harms <wharms@....de>, netdev@...r.kernel.org,
	Sjur Braendeland <sjur.brandeland@...ricsson.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	kernel-janitors@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [patch v2] caif: cleanup: remove duplicate checks

 Dan Carpenter <error27@...il.com> wrote:
> "phyinfo" can never be null here because we assigned it an address, so I
> removed both the assert and the second check inside the if statement.  I
> removed the "phyinfo->phy_layer != NULL" check as well because that was
> asserted earlier.
>
> Walter Harms suggested I move the "phyinfo->phy_ref_count++;" outside
> the if condition for readability, so I have done that.
>
> Signed-off-by: Dan Carpenter <error27@...il.com>
Acked-by: Sjur Braendeland <sjur.brandeland@...ricsson.com>
Thanks, this looks good.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html