netdev - Re: [PATCH] net/core: Save the port number a netdevice uses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100526084523.GA28748@mtldesk030.lab.mtl.com>
Date:	Wed, 26 May 2010 11:45:23 +0300
From:	Eli Cohen <eli@....mellanox.co.il>
To:	David Miller <davem@...emloft.net>
Cc:	eli@...lanox.co.il, netdev@...r.kernel.org,
	linux-rdma@...r.kernel.org, rdreier@...co.com,
	yevgenyp@...lanox.co.il
Subject: Re: [PATCH] net/core: Save the port number a netdevice uses

On Wed, May 26, 2010 at 01:39:26AM -0700, David Miller wrote:
> From: Eli Cohen <eli@...lanox.co.il>
> Date: Wed, 26 May 2010 11:17:02 +0300
> 
> > Today, there are no means to know which port of a hardware device a netdev
> > interface uses. This patch adds a new field to struct net_device that is used
> > to store this value. The network driver should use the SET_NETDEV_PORT_NUM()
> > macro to set the port number for the device it manages. For drivers that do not
> > set a value, a default value of 1 is set at alloc_netdev_mq().
> > This patch also makes use of this feature in the mlx4_en driver.
> > 
> > Signed-off-by: Eli Cohen <eli@...lanox.co.il>
> 
> We have an existing dev_id, use it.

Do you think we should use dev_id also for the sysfs file name so
every driver can choose to interpret this field as it chooses to, or
should I keep the sysfs file name as "port_number"?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html